gcp/service/cloud_security_scanner#373
Conversation
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
There was a problem hiding this comment.
Hi could you please include your json doc as well.
There was a problem hiding this comment.
Did you generate your plan.json?
| "condition": "starting_urls must not use insecure HTTP", | ||
| "attribute_path": ["starting_urls", 0], | ||
| "values": ["http://example.com"], | ||
| "policy_type": "blacklist", |
There was a problem hiding this comment.
Use pattern blacklist for this.
Sundi202
left a comment
There was a problem hiding this comment.
Hi your json document is missing and it seems like you did not generate a plan.json in your input folder because your terraform.lock is missing
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
There was a problem hiding this comment.
Hi please give this file a relatable policy name.
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
| @@ -0,0 +1,6 @@ | |||
| resource "google_security_scanner_scan_config" "c" { | |||
| provider = google-beta | |||
There was a problem hiding this comment.
values should match your c and nc attributes except the complaint and non-complaint values
Sundi202
left a comment
There was a problem hiding this comment.
Please resolve all comments and include the doc json file.
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
There was a problem hiding this comment.
Missing security impact and rationale
There was a problem hiding this comment.
Missing security impact and rationale
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
Summary
Added policies for the Terraform resource
google_security_scanner_scan_config.Implemented policy checks for:
starting_urlsmax_qpsexport_to_security_command_centerauthentication.custom_account.login_urlblacklist_patternsDocumentation
Added documentation explaining:
Documentation file:
docs/gcp/Cloud_Security_Scanner/google_security_scanner_scan_config.mdTesting
Tested each policy using:
c.tfnc.tfterraform plan -out=tfplanterraform show -json tfplanopa eval